Upgrade to AWS provider 3.0 and add EMR resource names to be configurable#43
Open
sarahkb125 wants to merge 9 commits intosegmentio:masterfrom
Open
Upgrade to AWS provider 3.0 and add EMR resource names to be configurable#43sarahkb125 wants to merge 9 commits intosegmentio:masterfrom
sarahkb125 wants to merge 9 commits intosegmentio:masterfrom
Conversation
luozhaoyu
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to merge 2 major changes (and one minor one).
Major changes:
master_group. I've added a variablemaster_instance_namethat is defaulted tomaster_groupto be backwards compatible, but also allows the user to abide by any naming conventions already put in place.segmnet_emr_autoscaling_policy-->segment_emr_autoscaling_policy