This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Update group and unsubscribe for parity with server-side integration INT-566#5
Open
Update group and unsubscribe for parity with server-side integration INT-566#5
Conversation
Current coverage is 100% (diff: 100%)@@ master #5 diff @@
===================================
Files 1 1
Lines 28 39 +11
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 28 39 +11
Misses 0 0
Partials 0 0
|
tsholmes
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unsubscribe call was non-functioning. I updated it to use the id of the
identify-d user and send it in the proper format.The server-side integration calls an undocumented api to update a user with the group traits. We just re-identify the user with the group traits, and vero merges them internally.