Fixed parameter typo, default value, and TypeError #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line15: this is not a bug, but this default parameter isn't equal with the corresponding default parameter setting in SGVF_PerFile.py, which may misleading user, then cause error (users tend to use default parameters), users can also set --x_coverage=0.01 to avoid error when running SGVF_cmd.py. line39: the parameter should correspond with previous parameter list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGVF_cmd.py
line15: this is not a bug, but this default parameter wasn't equal with the corresponding default parameter setting in SGVF_PerFile.py, which may misleading user, then cause error. Users can also set --x_coverage=0.01 to avoid error when running SGVF_cmd.py, but users always tend to use default parameters.
line39: the parameter should correspond with previous parameter list.
SGVFinder.py
line 32 and 35: It would trigger TypeError "cannot concatenate 'str' and 'int' objects" if variable type hadn't been explicitly declared or converted