Review x2x sector

[chrwm]

Please check the individual commits and commit messages for what is wrong.

General Feedback

1. Please ignore the first 2 commits: d1e0126 and 81279b0. The tables are test tables from Felix and not yours.
2. Only in table x2x_x2liquid_ft_1 you referenced the wacc from all_economic, see here: 6b025f1. In others you reference correctly from global_scalars.wacc
   {'x2x_x2liquid_ft_1': 'all_economic.wacc""'}
3. some tables (see commit and table below) have wrong versions in version column
   Some of them are from Felix

helper_x2x_ind_hfo               v1  None  None
helper_x2x_ind_lpg               v1  None  None
helper_x2x_ind_meoh_hydrogen     v1  None  None
helper_x2x_ind_methane           v1  None  None
helper_x2x_ind_mtg_mtk_hydrogen  v1  None  None
helper_x2x_ind_naphtha           v1  None  None
helper_x2x_ind_nh3_hydrogen      v1  None  None
x2x_import_coke_oven_gas         v3  None  None
x2x_import_elec                  v3  None  None
x2x_import_h2                    v3  None  None
x2x_import_natural_gas           v3  None  None
x2x_p2gas_aec                    v2    v1  None
x2x_x2gas_mpyr                   v2    v1  None
x2x_x2liquid_ft_1                v2    v1    v3

Questions

None

Generel impressions

Nearly perfect application of all conventions😍 . Only one minor problem- see commits

[Gian-M]

Regarding feedback point 2): I think I do not have access to adapt this process, as Hedda initialized the table on the OEP.
Regarding feedback point 3): all the helper_... components are actually components of Anik that he uses for industry, therefore please refer to him regarding the versioning errors. The other processes are actually all old processes (I am a bit confused that they are still there) and can be deleted, except for x2x_x2liquid_ft_1 which again is the process that Hedda initialized and that probably only she can adapt.

[chrwm]

In reponse to the comment above
The other processes are from Felix for testing purposes. @FelixMau can you delete your tables and switch to the new, most recent tables for your testing. Gian uploaded all his data, so the tables you're currently using should be already uploaded in an updated version.

@Gian-M to clarify: This old table: https://openenergyplatform.org/dataedit/view/model_draft/x2x_p2gas_aec
is replaced with its current version correct?: https://openenergyplatform.org/dataedit/view/model_draft/x2x_p2gas_aec_1
-> This means x2x_p2gas_aec is only a process that can be invested (suffix = _1) in and has no historic installed capacity, correct?

@HeddaGardian: can you delete the table and either upload it again with the corrections or send it over to Gian, so that he has control over the table

@anik-ier can you correct the version in your helper tables?

[FelixMau]

My tables should be deleted now. Sorry for confusion, should have added a test tag from the beginning onward in a more consistent way.

[FelixMau]

Would be great for me if the uploaded data could be registered on the databus as I am now unable to download my deleted test data.

[anik-ier]

@Gian-M, @chrwm - Helper tables versions are updated.

@FelixMau - All data from industries are registered to databus under SEDOS_industry_sector group name. please let me know if there any data you could not find and download.

[FelixMau]

@anik-ier thank you! So I should switch from using "SEDOS_Industry_draft" to "SEDOS_Industry_sector"? :)