You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities
Status: Unvalidated param type: The new product-version param sets value: 1.3 without quoting, which can be interpreted as a number instead of the expected string type in Tekton/Kubernetes resource schemas.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: Potential type mismatch: The new Tekton param value: 1.3 is unquoted and may be parsed as a numeric rather than a string, potentially failing schema validation or causing unexpected runtime behavior.
Enclose the product-version value in quotes to ensure it is parsed as a string rather than a float. This prevents potential formatting or type errors and aligns with the format of release-version.
Why: The suggestion correctly identifies that the version number 1.3 will be parsed as a float and recommends quoting it to ensure it's treated as a string, which is a best practice for version numbers and improves consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Add product-version parameter to Tekton pipeline configurations
Set product version to 1.3 across all pipeline definitions
Enables CPE label generation with product version information
Diagram Walkthrough
File Walkthrough
tuf-tool-pull-request.yaml
Add product-version parameter.tekton/tuf-tool-pull-request.yaml
product-versionparameter with value1.3release-versionin spec paramstuf-tool-push.yaml
Add product-version parameter.tekton/tuf-tool-push.yaml
product-versionparameter with value1.3release-versionin spec paramstuffer-pull-request.yaml
Add product-version parameter.tekton/tuffer-pull-request.yaml
product-versionparameter with value1.3release-versionin spec paramstuffer-push.yaml
Add product-version parameter.tekton/tuffer-push.yaml
product-versionparameter with value1.3release-versionin spec params