Skip to content

chore(KONFLUX-6210): fix and set name and cpe label for tuffer#115

Open
ralphbean wants to merge 1 commit intosecuresign:developfrom
ralphbean:develop-KONFLUX-6210-tuffer
Open

chore(KONFLUX-6210): fix and set name and cpe label for tuffer#115
ralphbean wants to merge 1 commit intosecuresign:developfrom
ralphbean:develop-KONFLUX-6210-tuffer

Conversation

@ralphbean
Copy link

@ralphbean ralphbean commented Sep 22, 2025

For https://issues.redhat.com/browse/KONFLUX-6210, clair needs access to a name and cpe label that it can use to look up the image in VEX statements.

See also release-engineering/rhtap-ec-policy#149

Signed-off-by: Ralph Bean rbean@redhat.com
Assisted-by: Gemini

Summary by Sourcery

Build:

  • Include 'name' and 'cpe' LABELs in Dockerfile.tuffer for Clair compatibility

For https://issues.redhat.com/browse/KONFLUX-6210, clair needs access to a name and cpe label that it can use to look up the image in VEX statements.

See also release-engineering/rhtap-ec-policy#149

Signed-off-by: Ralph Bean <rbean@redhat.com>
Assisted-by: Gemini
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances Dockerfile.tuffer by correcting and adding image metadata labels—specifically setting the name and CPE label—to enable Clair to perform VEX-based lookups.

File-Level Changes

Change Details Files
Enhance image metadata with correct name and CPE labels
  • Update the 'name' label to 'tuffer'
  • Add the 'cpe' label to match VEX lookup requirements
Dockerfile.tuffer

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@qodo-code-review
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Label Validity

Verify that the new name and CPE labels match the registry/release conventions and what Clair expects (correct namespace, versioning, and CPE syntax) to avoid mis-indexing.

LABEL name="rhtas/tuffer-rhel9"
LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:1.2::el9"
CPE Accuracy

Confirm the CPE value corresponds to the correct product, version, and edition for RHTAS on RHEL 9; ensure the use of application CPE form and correct version (e.g., 1.2) aligns with published CPEs.

LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:1.2::el9"

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Avoid hardcoding version in CPE label

Replace the hardcoded version 1.2 in the cpe LABEL with a build argument, such
as ${RHTAS_VERSION}, to improve maintainability and ensure metadata accuracy.

Dockerfile.tuffer [27]

-LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:1.2::el9"
+LABEL cpe="cpe:/a:redhat:trusted_artifact_signer:${RHTAS_VERSION}::el9"
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies a hardcoded version in the cpe label and proposes using a build argument, which is a best practice that improves the Dockerfile's maintainability.

Low
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant