Conversation
Reviewer's GuideThis PR integrates Model Validation Operator (MVO) support into structural tests by adding parsing logic, constants, regex updates, documentation tweaks, and a full suite of acceptance tests under test/acceptance/model_transparency. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- ParseMVOperatorImages duplicates much of the PC parsing logic—consider extracting a common helper or parameterizing ParsePCOperatorImages to avoid code duplication.
- The regex-based image extraction in ParseMVOperatorImages is brittle; using a YAML parser or reusing the existing image‐parsing utilities would be more robust and maintainable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- ParseMVOperatorImages duplicates much of the PC parsing logic—consider extracting a common helper or parameterizing ParsePCOperatorImages to avoid code duplication.
- The regex-based image extraction in ParseMVOperatorImages is brittle; using a YAML parser or reusing the existing image‐parsing utilities would be more robust and maintainable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: SequeI <asiek@redhat.com>
JasonPowr
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for Model Validation Operator to structural tests by extending parsing utilities, adding new image keys and constants, updating snapshot logic, and introducing dedicated acceptance test suites (operator images, file-based catalogs, and release validations) with accompanying README instructions.
New Features:
Enhancements:
Documentation:
Tests: