Skip to content

fix: increase search result timeout from 5s to 15s#57

Merged
kdacosta0 merged 1 commit intomainfrom
kdacosta/increase-ui-test-timeout
Nov 28, 2025
Merged

fix: increase search result timeout from 5s to 15s#57
kdacosta0 merged 1 commit intomainfrom
kdacosta/increase-ui-test-timeout

Conversation

@kdacosta0
Copy link
Member

@kdacosta0 kdacosta0 commented Nov 28, 2025

Summary by Sourcery

Tests:

  • Extend the Playwright locator wait timeout for search result cards from 5s to 15s in the Rekor search sign/verify browser test.

Signed-off-by: Kristian Da Costa Menezes <kdacosta@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the Playwright-based UI test wait timeout for search result cards from 5 seconds to 15 seconds to reduce test flakiness when search results are slow to appear.

File-Level Changes

Change Details Files
Increase the UI test timeout for search result card visibility to handle slower search responses.
  • Updated the Playwright locator WaitFor timeout value from 5,000 ms to 15,000 ms for search result cards
  • Retained the existing visibility wait state and error handling while only adjusting the timeout duration
test/rekorsearchui/rekor_search_sign_verify_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider keeping the numeric separator for readability (e.g., 15_000 instead of 15000) to be consistent with the previous style and make the timeout value easier to scan.
  • You might want to extract the timeout value into a named constant (e.g., searchResultTimeout) so it’s easier to adjust in one place and self-documents the purpose of the 15s delay.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider keeping the numeric separator for readability (e.g., `15_000` instead of `15000`) to be consistent with the previous style and make the timeout value easier to scan.
- You might want to extract the timeout value into a named constant (e.g., `searchResultTimeout`) so it’s easier to adjust in one place and self-documents the purpose of the 15s delay.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kdacosta0
Copy link
Member Author

@kdacosta0 kdacosta0 requested a review from bouskaJ November 28, 2025 11:51
@kdacosta0 kdacosta0 merged commit dc2b40b into main Nov 28, 2025
5 checks passed
@kdacosta0 kdacosta0 deleted the kdacosta/increase-ui-test-timeout branch November 28, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants