fix: increase search result timeout from 5s to 15s#57
Merged
Conversation
Signed-off-by: Kristian Da Costa Menezes <kdacosta@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtends the Playwright-based UI test wait timeout for search result cards from 5 seconds to 15 seconds to reduce test flakiness when search results are slow to appear. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider keeping the numeric separator for readability (e.g.,
15_000instead of15000) to be consistent with the previous style and make the timeout value easier to scan. - You might want to extract the timeout value into a named constant (e.g.,
searchResultTimeout) so it’s easier to adjust in one place and self-documents the purpose of the 15s delay.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider keeping the numeric separator for readability (e.g., `15_000` instead of `15000`) to be consistent with the previous style and make the timeout value easier to scan.
- You might want to extract the timeout value into a named constant (e.g., `searchResultTimeout`) so it’s easier to adjust in one place and self-documents the purpose of the 15s delay.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
tests failing on timeout for commitSHA scenario https://github.com/securesign/secure-sign-operator/actions/runs/19761596361/job/56624843082?pr=1478 |
bouskaJ
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Tests: