Skip to content

feat: pass ssl cert environment variables to cli#55

Closed
osmman wants to merge 1 commit intomainfrom
tturek/cli-envs
Closed

feat: pass ssl cert environment variables to cli#55
osmman wants to merge 1 commit intomainfrom
tturek/cli-envs

Conversation

@osmman
Copy link
Contributor

@osmman osmman commented Jul 15, 2025

Pass SSL_CERT_DIR and SSL_CERT_FILE env variables from main process to child cli processes.

Summary by Sourcery

New Features:

  • Propagate SSL_CERT_DIR and SSL_CERT_FILE from the parent process to spawned CLI commands

Pass SSL_CERT_DIR and SSL_CERT_FILE env variables from main process
to child cli processes.

Signed-off-by: Tomas Turek <tturek@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 15, 2025

Reviewer's Guide

Commands now include SSL_CERT_DIR and SSL_CERT_FILE from the parent process when spawning child CLI subprocesses in both Command and CommandOutput methods.

Sequence diagram for passing SSL cert environment variables to CLI subprocesses

sequenceDiagram
    participant ParentProcess as Parent Process
    participant CLI as cli.Command/cli.CommandOutput
    participant Subprocess as CLI Subprocess
    ParentProcess->>CLI: Call Command/CommandOutput(...)
    CLI->>ParentProcess: Read SSL_CERT_DIR and SSL_CERT_FILE from environment
    CLI->>Subprocess: Start subprocess with SSL_CERT_DIR and SSL_CERT_FILE in env
    Subprocess-->>CLI: Execute CLI logic with provided env
    CLI-->>ParentProcess: Return result/output
Loading

Class diagram for updated cli methods handling environment variables

classDiagram
    class cli {
        +Command(ctx, args)
        +CommandOutput(ctx, args)
    }
    cli : +Command now sets cmd.Env with SSL_CERT_DIR and SSL_CERT_FILE if present
    cli : +CommandOutput now sets cmd.Env with SSL_CERT_DIR and SSL_CERT_FILE if present
Loading

File-Level Changes

Change Details Files
Propagate SSL certificate environment variables to CLI subprocesses
  • Initialize envs slice to collect SSL vars
  • Lookup SSL_CERT_DIR and SSL_CERT_FILE via os.LookupEnv
  • Append found SSL vars to cmd.Env in both Command and CommandOutput
pkg/clients/cli.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @osmman - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@kdacosta0 kdacosta0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting cmd.Env wipes the entire environment, including (PATH, etc.), which will cause the command to fail. I believe you need to append to the current environment instead of replacing it.

	cmd.Env = append(cmd.Env, "SSL_CERT_DIR="+val)

@osmman osmman marked this pull request as draft July 15, 2025 12:02
@osmman osmman closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants