Skip to content

test: run headless browser with no sandbox#54

Closed
osmman wants to merge 1 commit intomainfrom
tturek/no-sandbox
Closed

test: run headless browser with no sandbox#54
osmman wants to merge 1 commit intomainfrom
tturek/no-sandbox

Conversation

@osmman
Copy link
Contributor

@osmman osmman commented Jun 17, 2025

Summary by Sourcery

Enable no-sandbox mode for headless browser launches in Rekor Search UI tests.

Enhancements:

  • Simplify launcher initialization by removing unused headless variable

Tests:

  • Add NoSandbox flag to headless browser launcher when running headless

Signed-off-by: Tomas Turek <tturek@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 17, 2025

Reviewer's Guide

Refactors the Rekor Search UI test to initialize the browser launcher unconditionally and conditionally apply headless mode with no sandbox when the HEADLESS_UI flag is set.

File-Level Changes

Change Details Files
Browser launcher setup was refactored to support conditional headless mode with no-sandbox.
  • Removed direct headless flag in launcher initialization
  • Instantiated launcher unconditionally via launcher.New()
  • Added conditional block checking HEADLESS_UI env var
  • Applied Headless(true) and NoSandbox(true) within the block
test/rekorsearchui/rekor_search_sign_verify_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @osmman - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@osmman osmman closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant