Skip to content

[Konflux as Code] Reactivating tough v1.2.#366

Merged
petrpinkas merged 1 commit intomainfrom
tdalton/ActivateToughV1.2
Jan 23, 2026
Merged

[Konflux as Code] Reactivating tough v1.2.#366
petrpinkas merged 1 commit intomainfrom
tdalton/ActivateToughV1.2

Conversation

@tommyd450
Copy link
Contributor

@tommyd450 tommyd450 commented Jan 23, 2026

PR Type

Enhancement


Description

  • Remove tough v1.2 exclusion patch from Konflux configuration

  • Delete unused exclude-tough.yaml patch file

  • Reactivate tough component in RHTAS stream overlay


Diagram Walkthrough

flowchart LR
  A["kustomization.yaml"] -- "remove patch reference" --> B["exclude-tough.yaml removed"]
  C["exclude-tough.yaml"] -- "delete file" --> D["tough component reactivated"]
Loading

File Walkthrough

Relevant files
Configuration changes
kustomization.yaml
Remove tough exclusion patch reference                                     

konflux-configs/base/stream/rhtas/overlay/v1-2/kustomization.yaml

  • Removed reference to patch/exclude-tough.yaml from patches list
  • Kept other patches including stream.yaml, mintmaker.yaml, and
    exclude-rekor-monitor.yaml intact
+0/-1     
exclude-tough.yaml
Delete tough exclusion patch file                                               

konflux-configs/base/stream/rhtas/overlay/v1-2/patch/exclude-tough.yaml

  • Deleted entire file that contained ProjectDevelopmentStream deletion
    patch for tough component
  • File previously excluded tough from the RHTAS stream overlay
+0/-5     

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions
Copy link

Configuration Diff

1 document(s) impacted:

+ 1 added
- 0 removed
! 0 modified
Diff
@@ (root level) @@
# projctl.konflux.dev/v1beta1/ProjectDevelopmentStream/rhtas-tenant/tough-v1-2
! + one document added:
+   ---
+   apiVersion: projctl.konflux.dev/v1beta1
+   kind: ProjectDevelopmentStream
+   metadata:
+     name: tough-v1-2
+     namespace: rhtas-tenant
+   spec:
+     project: tough
+     template:
+       name: tough-template
+       values:
+       - name: version
+         value: v1.2
+       - name: branch
+         value: release-1.2
+       - name: mintmakerDisabled
+         value: "true"

📦 Artifacts: base-output.yaml, head-output.yaml, dyff-output.txt

@tommyd450 tommyd450 requested a review from osmman January 23, 2026 08:36
@petrpinkas petrpinkas merged commit 916fb9a into main Jan 23, 2026
4 checks passed
@petrpinkas petrpinkas deleted the tdalton/ActivateToughV1.2 branch January 23, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants