Skip to content

feat: Add support for rekor-monitor and segment-backup-job#359

Merged
tommyd450 merged 1 commit intosecuresign:tdalton/TasComponentsfrom
knrc:TasComponents
Jan 21, 2026
Merged

feat: Add support for rekor-monitor and segment-backup-job#359
tommyd450 merged 1 commit intosecuresign:tdalton/TasComponentsfrom
knrc:TasComponents

Conversation

@knrc
Copy link
Contributor

@knrc knrc commented Jan 19, 2026

No description provided.


resources:
- overlay/ansible
- overlay/rekor-monitor
Copy link
Contributor

@tommyd450 tommyd450 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Apologies I may not have been clear, by including them on my branch I meant that we should try include Rekor-Monitor and Segment-backup under Tas-Components like what is being done with say rekor and fulcio in my original pr. So rather than them having their own overlays we want them within Tas-Components as components. If im making sense?

Copy link
Contributor

@tommyd450 tommyd450 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So essentially anything that distinguish them as their own application in konflux we do not want as we are trying to reduce having many applications. Certain things such as RHTAS-Console and tough being exceptions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring my previous comments lets group rekor-monitor under tas-components but lets keep segment as is as we are intending to deprecate it in the future and having it seperate now is easier!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that's not possible since rekor-monitor isn't supported in 1.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same with segment-backup-job, it's only supported in 1.2 and 1.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, totally agree, just reiterating here for clarity that I was misunderstanding initially hence the original ask!

@tommyd450 tommyd450 force-pushed the tdalton/TasComponents branch from fc52ac5 to f5ee492 Compare January 20, 2026 11:28
@osmman
Copy link
Contributor

osmman commented Jan 20, 2026

/ok-to-test

Signed-off-by: Kevin Conner <kconner@redhat.com>
@tommyd450 tommyd450 merged commit 12ada55 into securesign:tdalton/TasComponents Jan 21, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants