Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new GitHub Actions workflow that allows manual triggering of the Konflux build by invoking a reusable workflow. Flow diagram for manual Konflux build triggerflowchart TD
Start([Manual trigger via workflow_dispatch]) --> Trigger["Trigger Konflux build workflow"]
Trigger --> Reusable["Invoke reusable workflow (securesign/actions/trigger-konflux-build)"]
Reusable --> End([Konflux build started])
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
| uses: securesign/actions/.github/workflows/trigger-konflux-build.yaml@main | ||
| with: | ||
| branch: main | ||
| secrets: | ||
| token: ${{ secrets.GITHUB_TOKEN }} No newline at end of file |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix this problem, we should add a permissions key at the job level (within the trigger-konflux-build job) or at the workflow root. Since this workflow simply triggers a reusable workflow, the safest starting point is to restrict permissions to read-only, unless there are explicit reasons for broader access. The minimal appropriate block is usually contents: read, which provides read access to the repository code, or an even more restrictive block if possible (e.g., none). The explicit block prevents the GITHUB_TOKEN from being granted unnecessary privileges for this triggering job. The change is to insert the permissions: key immediately above or within the job definition.
| @@ -4,6 +4,8 @@ | ||
|
|
||
| jobs: | ||
| trigger-konflux-build: | ||
| permissions: | ||
| contents: read | ||
| uses: securesign/actions/.github/workflows/trigger-konflux-build.yaml@main | ||
| with: | ||
| branch: main |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
Summary by Sourcery
CI: