chore(tekton): remove obsolete pipelines and standardize naming

[osmman]

User description

• Remove deprecated FBC pipelines for OCP v4.13, v4.14, and v4.15
• Remove MVO (model-validation-operator) FBC pipelines for v4.14-v4.20
• Remove PCO (policy-controller-operator) FBC pipelines for v4.14-v4.20
• Remove unused project_resources templates
• Rename remaining FBC pipelines with 'rhtas-' prefix for consistency
• Update PipelineRun names from fbc-* to rhtas-fbc-* in metadata

---

PR Type

Enhancement

---

Description

• Remove deprecated FBC pipelines for OCP v4.13, v4.14, v4.15

• Remove MVO FBC pipelines for OCP v4.14-v4.20

• Remove PCO FBC pipelines for OCP v4.14-v4.20

• Remove unused project resource templates and definitions

• Standardize remaining pipelines with rhtas-fbc- naming convention

• Update application/component labels and service account names for consistency

---

Diagram Walkthrough

flowchart LR
  A["Deprecated FBC Pipelines<br/>v4.13-v4.15"] -->|Delete| B["Cleaned Pipeline Set"]
  C["MVO/PCO FBC Pipelines<br/>v4.14-v4.20"] -->|Delete| B
  D["Project Resources<br/>Templates"] -->|Delete| B
  E["RHTAS FBC Pipelines<br/>v4.16-v4.20"] -->|Rename & Update| F["Standardized Pipelines<br/>rhtas-fbc-* naming"]
  B --> F

Loading

File Walkthrough

	Relevant files
Deletion	37 files fbc-v4-13-pull-request.yaml Remove deprecated OCP v4.13 FBC pipeline                                  +0/-49    fbc-v4-13-push.yaml Remove deprecated OCP v4.13 FBC pipeline                                  +0/-46    fbc-v4-14-pull-request.yaml Remove deprecated OCP v4.14 FBC pipeline                                  +0/-49    fbc-v4-14-push.yaml Remove deprecated OCP v4.14 FBC pipeline                                  +0/-46    fbc-v4-15-pull-request.yaml Remove deprecated OCP v4.15 FBC pipeline                                  +0/-49    fbc-v4-15-push.yaml Remove deprecated OCP v4.15 FBC pipeline                                  +0/-46    mvo-fbc-v4-14-pull-request.yaml Remove MVO FBC v4.14 pull request pipeline                              +0/-66    mvo-fbc-v4-14-push.yaml Remove MVO FBC v4.14 push pipeline                                              +0/-50    mvo-fbc-v4-15-pull-request.yaml Remove MVO FBC v4.15 pull request pipeline                              +0/-53    mvo-fbc-v4-15-push.yaml Remove MVO FBC v4.15 push pipeline                                              +0/-50    mvo-fbc-v4-16-pull-request.yaml Remove MVO FBC v4.16 pull request pipeline                              +0/-55    mvo-fbc-v4-16-push.yaml Remove MVO FBC v4.16 push pipeline                                              +0/-52    mvo-fbc-v4-17-pull-request.yaml Remove MVO FBC v4.17 pull request pipeline                              +0/-55    mvo-fbc-v4-17-push.yaml Remove MVO FBC v4.17 push pipeline                                              +0/-52    mvo-fbc-v4-18-pull-request.yaml Remove MVO FBC v4.18 pull request pipeline                              +0/-55    mvo-fbc-v4-18-push.yaml Remove MVO FBC v4.18 push pipeline                                              +0/-52    mvo-fbc-v4-19-pull-request.yaml Remove MVO FBC v4.19 pull request pipeline                              +0/-55    mvo-fbc-v4-19-push.yaml Remove MVO FBC v4.19 push pipeline                                              +0/-52    mvo-fbc-v4-20-pull-request.yaml Remove MVO FBC v4.20 pull request pipeline                              +0/-55    mvo-fbc-v4-20-push.yaml Remove MVO FBC v4.20 push pipeline                                              +0/-52    pco-fbc-v4-14-pull-request.yaml Remove PCO FBC v4.14 pull request pipeline                              +0/-53    pco-fbc-v4-14-push.yaml Remove PCO FBC v4.14 push pipeline                                              +0/-50    pco-fbc-v4-15-pull-request.yaml Remove PCO FBC v4.15 pull request pipeline                              +0/-53    pco-fbc-v4-15-push.yaml Remove PCO FBC v4.15 push pipeline                                              +0/-50    pco-fbc-v4-16-pull-request.yaml Remove PCO FBC v4.16 pull request pipeline                              +0/-55    pco-fbc-v4-16-push.yaml Remove PCO FBC v4.16 push pipeline                                              +0/-52    pco-fbc-v4-17-pull-request.yaml Remove PCO FBC v4.17 pull request pipeline                              +0/-55    pco-fbc-v4-17-push.yaml Remove PCO FBC v4.17 push pipeline                                              +0/-52    pco-fbc-v4-18-pull-request.yaml Remove PCO FBC v4.18 pull request pipeline                              +0/-55    pco-fbc-v4-18-push.yaml Remove PCO FBC v4.18 push pipeline                                              +0/-52    pco-fbc-v4-19-pull-request.yaml Remove PCO FBC v4.19 pull request pipeline                              +0/-55    pco-fbc-v4-19-push.yaml Remove PCO FBC v4.19 push pipeline                                              +0/-52    pco-fbc-v4-20-pull-request.yaml Remove PCO FBC v4.20 pull request pipeline                              +0/-55    pco-fbc-v4-20-push.yaml Remove PCO FBC v4.20 push pipeline                                              +0/-52    devstream.yaml Remove project development stream templates                            +0/-175  project.yaml Remove project resource definition                                              +0/-8      template.yaml Remove project template resource                                                  +0/-41
Enhancement	10 files rhtas-fbc-v4-16-pull-request.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-16-push.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-17-pull-request.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-17-push.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-18-pull-request.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-18-push.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-19-pull-request.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-19-push.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-20-pull-request.yaml Standardize naming and update metadata labels                        +4/-4      rhtas-fbc-v4-20-push.yaml Standardize naming and update metadata labels                        +4/-4

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Typo in name: The new serviceAccountName contains a likely typo (bbuild-pipeline-rhtas-fbc-stage-v4-17) which is inconsistent with the standardized naming and reduces clarity. Referred Code serviceAccountName: bbuild-pipeline-rhtas-fbc-stage-v4-17 workspaces: Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix serviceAccountName typo Fix the typo in serviceAccountName by removing the extra leading "b". .tekton/rhtas-fbc-v4-17-pull-request.yaml [46] -serviceAccountName: bbuild-pipeline-rhtas-fbc-stage-v4-17 +serviceAccountName: build-pipeline-rhtas-fbc-stage-v4-17 Apply / Chat Suggestion importance[1-10]: 9 __ Why: This suggestion correctly identifies a critical typo in the serviceAccountName which would cause the pipeline run to fail.	High
High-level	Consider using a templating tool To reduce configuration duplication and improve maintainability across the numerous similar Tekton PipelineRun YAML files, adopt a templating tool like Kustomize or Helm. This will enable defining a common base configuration and applying version-specific overlays. Examples: .tekton/rhtas-fbc-v4-16-pull-request.yaml [1-51] apiVersion: tekton.dev/v1 kind: PipelineRun metadata: annotations: build.appstudio.openshift.io/repo: https://github.com/securesign/fbc?rev={{revision}} build.appstudio.redhat.com/commit_sha: '{{revision}}' build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}' build.appstudio.redhat.com/target_branch: '{{target_branch}}' pipelinesascode.tekton.dev/max-keep-runs: "3" pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch ... (clipped 41 lines) .tekton/rhtas-fbc-v4-17-pull-request.yaml [1-51] apiVersion: tekton.dev/v1 kind: PipelineRun metadata: annotations: build.appstudio.openshift.io/repo: https://github.com/securesign/fbc?rev={{revision}} build.appstudio.redhat.com/commit_sha: '{{revision}}' build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}' build.appstudio.redhat.com/target_branch: '{{target_branch}}' pipelinesascode.tekton.dev/max-keep-runs: "3" pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch ... (clipped 41 lines) Solution Walkthrough: Before: # .tekton/rhtas-fbc-v4-16-pull-request.yaml apiVersion: tekton.dev/v1 kind: PipelineRun metadata: name: fbc-v4-16-on-pull-request labels: component: rhtas-fbc-stage-v4-16 annotations: on-cel-expression: '... "v4.16/rhtas-operator/***".pathChanged() ...' spec: params: - name: path-context value: v4.16/rhtas-operator ... # .tekton/rhtas-fbc-v4-17-pull-request.yaml # ... similar content with "v4-17" ... After: # kustomize/base/pipelinerun.yaml apiVersion: tekton.dev/v1 kind: PipelineRun metadata: name: rhtas-fbc-on-pull-request labels: component: rhtas-fbc-stage annotations: on-cel-expression: '...' spec: params: - name: path-context value: path/to/operator ... # kustomize/overlays/v4-16/kustomization.yaml bases: - ../../base patches: - target: ... patch: |- - op: replace path: /metadata/name value: rhtas-fbc-v4-16-on-pull-request - op: replace path: /spec/params/0/value value: v4.16/rhtas-operator Suggestion importance[1-10]: 8 __ Why: This is a significant architectural suggestion that correctly identifies widespread duplication across many YAML files and proposes a valid solution to improve maintainability and reduce errors, such as the typo found in rhtas-fbc-v4-17-pull-request.yaml.	Medium
General	Align pipelineRun name Update the PipelineRun name to align with the rhtas-fbc-stage naming convention for consistency. .tekton/rhtas-fbc-v4-16-pull-request.yaml [18] -name: fbc-v4-16-on-pull-request +name: rhtas-fbc-stage-v4-16-on-pull-request Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly points out an inconsistency between the resource name and the updated labels, improving maintainability and clarity.	Low
	Rename push pipelineRun Update the push PipelineRun name to follow the rhtas-fbc-stage convention for consistency. .tekton/rhtas-fbc-v4-16-push.yaml [17] -name: fbc-v4-16-on-push +name: rhtas-fbc-stage-v4-16-on-push Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly points out an inconsistency between the resource name and the updated labels, improving maintainability and clarity.	Low
Update

[osmman]

/retest