implement memory.fill and memory.copy#4
implement memory.fill and memory.copy#4zeldovich wants to merge 1 commit intosecure-foundations:mainfrom
Conversation
|
Thanks Nickolai! Similar to #5 (comment) it'd be helpful to know the version so I can do a quick test before merging. I think the code in this PR generally seems reasonable but OOB traps are a concern that I have for both of the operations (ref. https://webassembly.github.io/spec/core/exec/instructions.html#xref-syntax-instructions-syntax-instr-memory-mathsf-memory-copy-x-1-x-2) that might need to be fixed before merging. |
|
Here's a small test case that demonstrates what this PR enables, on Arch Linux: this uses On the current latest rWasm, I get: with this PR's change, I get: |
|
Regarding OOB traps, I was expecting this would be handled by |
This adds support for
memory.copyandmemory.fillopcodes that are used by recent WASM toolchains, including clang.