-
Notifications
You must be signed in to change notification settings - Fork 89
Removal of "${ }" characters and subnet variables #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
As per the terrafrom deprecation the "${ }" characters surrounding environment variables have been removed.
Local variables assigning the subnet in each file has been corrected.
|
Thank you for the PR - My initial test of similar changes prior to the BH Arsenal presentation were not fully successful. I think the newest version of terraform requires a bit more testing. I'll add this to my to-do list and circle back once I resume development and confirm CICD test will pass validation. Thanks again! |
|
This addresses #68 - just received notice that Terraform v0.12.20 has been released. Definitely have a bunch of testing to perform & need to confirm Circle CI is using the latest image - which it appears it is : circleci terraform latest config |
|
working on the cicd pipeline and adding terraform checks, I've updated an open issues with the details on the terraform failures. I've pushed passed those issues & cicd builds are almost all green again. I'll look to merge these into the pipeline with this effort as well |
As per the issue raised by cappetta about the terraform v0.12.15 deprecation of the "${ }" characters in the HCL language the characters have been removed from the indicated files.
In addition the local variables assigning the subnet in each of the .tf files in assets has been modified. This is due to an issue with public IPs being assigned to each instance on launch.