Skip to content

Conversation

@thewilkybarkid
Copy link

Currently resources are compared by their internal ID. For readable streams, it would be useful to compare their content. This tries to read (and reset) the resource, and compares the hashed results.

(Refs libero/content-api-bundle#5 (comment))

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #65 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     99.07%   99.11%   +0.03%     
- Complexity      123      127       +4     
============================================
  Files            15       15              
  Lines           325      338      +13     
============================================
+ Hits            322      335      +13     
  Misses            3        3
Impacted Files Coverage Δ Complexity Δ
src/ResourceComparator.php 100% <100%> (ø) 8 <4> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bdadd...fe3cbff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants