Merged
Conversation
Contributor
korgon
commented
Dec 30, 2025
korgon
commented
- locking in the libsodium dependency
There was a problem hiding this comment.
Pull request overview
This PR locks the libsodium-wrappers dependency to a specific version (0.7.15) by removing the caret (^) prefix, preventing automatic minor and patch version updates.
Key Changes
- Updated
libsodium-wrappersfrom^0.7.13to exact version0.7.15
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "glob": "^9.3.5", | ||
| "inquirer": "^8.2.4", | ||
| "libsodium-wrappers": "^0.7.13", | ||
| "libsodium-wrappers": "0.7.15", |
There was a problem hiding this comment.
While locking the dependency version provides reproducibility, the version jumped from ^0.7.13 to 0.7.15 without maintaining consistency with other dependencies in the file (which use caret ranges). Consider documenting why this specific version needs to be locked, or apply the same locking strategy to other security-critical dependencies for consistency.
Suggested change
| "libsodium-wrappers": "0.7.15", | |
| "libsodium-wrappers": "^0.7.15", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.