Skip to content

Misc Fixes#1458

Merged
korgon merged 3 commits intodevelopfrom
misc-fixes
Mar 6, 2026
Merged

Misc Fixes#1458
korgon merged 3 commits intodevelopfrom
misc-fixes

Conversation

@korgon
Copy link
Contributor

@korgon korgon commented Mar 6, 2026

  • removing modern.js (was causing delayed render)
  • updating husky version
  • removing demo store upload to production (keeping tag version)

Copilot AI review requested due to automatic review settings March 6, 2026 00:52
@korgon korgon linked an issue Mar 6, 2026 that may be closed by this pull request
@korgon korgon changed the base branch from main to develop March 6, 2026 00:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the Preact demo bundle entrypoint (removing the separate modern.ts indirection), updates Husky, and adjusts docs deployment to stop syncing demo assets to the production S3 path.

Changes:

  • Switch modern builds to use src/index.ts directly and remove src/modern.ts; add a webpack banner to set window.searchspring.managed.
  • Update Husky from 7.0.4 to 9.1.7 and adjust hook/script wiring.
  • Remove demo store uploads to the snap/production S3 path in the docs workflow.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/snap-preact-demo/webpack.universal.js Removes production devServer config from the universal build.
packages/snap-preact-demo/webpack.modern.js Points production modern build entry to src/index.ts and removes devServer config.
packages/snap-preact-demo/webpack.dev.js Points dev modern build entry to src/index.ts and tweaks dev-server client logging.
packages/snap-preact-demo/webpack.common.js Adds a BannerPlugin to set window.searchspring.managed.
packages/snap-preact-demo/src/modern.ts Removes the former modern entry shim.
package.json Updates Husky version and removes the prepare script.
package-lock.json Updates lockfile entries for Husky 9.1.7 (incl. Node engine).
.husky/pre-commit Simplifies the hook script to only run npx lint-staged.
.github/workflows/docs.yml Stops syncing demo artifacts to snap/production.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@korgon korgon requested a review from dkonieczek March 6, 2026 01:09
@korgon korgon merged commit 3f61d6a into develop Mar 6, 2026
5 checks passed
@korgon korgon deleted the misc-fixes branch March 6, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alter S3 Upload

3 participants