Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the Preact demo bundle entrypoint (removing the separate modern.ts indirection), updates Husky, and adjusts docs deployment to stop syncing demo assets to the production S3 path.
Changes:
- Switch modern builds to use
src/index.tsdirectly and removesrc/modern.ts; add a webpack banner to setwindow.searchspring.managed. - Update Husky from 7.0.4 to 9.1.7 and adjust hook/script wiring.
- Remove demo store uploads to the
snap/productionS3 path in the docs workflow.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/snap-preact-demo/webpack.universal.js | Removes production devServer config from the universal build. |
| packages/snap-preact-demo/webpack.modern.js | Points production modern build entry to src/index.ts and removes devServer config. |
| packages/snap-preact-demo/webpack.dev.js | Points dev modern build entry to src/index.ts and tweaks dev-server client logging. |
| packages/snap-preact-demo/webpack.common.js | Adds a BannerPlugin to set window.searchspring.managed. |
| packages/snap-preact-demo/src/modern.ts | Removes the former modern entry shim. |
| package.json | Updates Husky version and removes the prepare script. |
| package-lock.json | Updates lockfile entries for Husky 9.1.7 (incl. Node engine). |
| .husky/pre-commit | Simplifies the hook script to only run npx lint-staged. |
| .github/workflows/docs.yml | Stops syncing demo artifacts to snap/production. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkonieczek
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
production(keeping tag version)