[pull] master from unlock-protocol:master#123
Merged
pull[bot] merged 3 commits intosearchableguy:masterfrom Mar 21, 2026
Merged
[pull] master from unlock-protocol:master#123pull[bot] merged 3 commits intosearchableguy:masterfrom
pull[bot] merged 3 commits intosearchableguy:masterfrom
Conversation
* feat: add governance proposal read paths * chore: update yarn.lock for ethers dependency in governance-app Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ci: remove deploy-vercel script and fix Vercel ignore command - Remove governance-app/scripts/deploy-vercel.sh (replaced by native Vercel integration) - Add ignoreCommand to watch governance-app/ and yarn.lock changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ci: fix Vercel ignoreCommand to use paths relative to project root Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: fetch governance proposals from subgraph instead of RPC queryFilter The eth_getLogs range from governorStartBlock (~1.75M) to latest (~29M) is too large for the default RPC provider, causing the governance app homepage to fail with an RPC error. Migrates proposal fetching to the subgraph (already fully synced), keeping only simple contract calls (proposalThreshold, votingDelay, votingPeriod) and getLatestTimestamp() on RPC. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use BigInt arithmetic in percentage() to avoid precision loss Number(bigint) loses precision for token amounts > Number.MAX_SAFE_INTEGER. Since UP token has 18 decimals, raw wei values exceed this threshold for any real vote. Keep the division in BigInt space, only converting the small result. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: hardcode governance subgraph URL and improve error visibility - Hardcode subgraph.unlock-protocol.com/8453 as the default governance subgraph URL instead of relying on base.subgraph.endpoint (same URL but now explicit and decoupled from the networks package) - Add console.error to all error boundaries so failures are visible in Vercel logs - Update error messages to reference the subgraph instead of RPC - Remove "indexed from RPC" label from proposals count Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: remove hardcoded tokenSymbol from config, already fetched via symbol() on-chain Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: fetch tokenSymbol from contract instead of hardcoding it in config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )