[Q&A] Risky file permission enable in linter and explicitely disabled in codebase#885
Merged
insatomcat merged 1 commit intoseapath:mainfrom Mar 3, 2026
Merged
Conversation
…debase Signed-off-by: Antoine Dupre <antoine.dupre@savoirfairelinux.com>
insatomcat
force-pushed
the
linter-permission-files
branch
from
a8ef855 to
50bf115
Compare
insatomcat
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the
risky-file-permissionsansible-lint rule, which was previously skipped globally inansible-lint.conf.Going forward, all new contributions that create or copy files must explicitly set file permissions. This ensures we maintain clear and intentional permission settings across the project.
For existing tasks that are currently missing explicit permissions, this PR adds
# noqa: risky-file-permissionsannotations rather than guessing the intended permissions for each task. This allows us to enable the rule immediately without risking unintended behavioral changes.In practice, all these tasks currently end up with
0644for files and0755for directories. This is determined by the defaultumask 0022, which is the standard default on all four supported distributions (Debian, CentOS, OracleLinux, Yocto). Nothing in this repository modifies theumask. So while the current behavior is reasonable, the permissions are implicit rather than explicit. The #noqa tags acknowledge this technical debt, without introducing new files without mode.
Each annotated task can be revisited individually in future commits to set explicit permissions where appropriate.