Skip to content

[Fix] Remove docker service tasks#883

Merged
insatomcat merged 1 commit intoseapath:mainfrom
AntoineDupre:docker-service-enable
Mar 3, 2026
Merged

[Fix] Remove docker service tasks#883
insatomcat merged 1 commit intoseapath:mainfrom
AntoineDupre:docker-service-enable

Conversation

@AntoineDupre
Copy link
Contributor

Enable docker service tasks does nothing on roles:

  • roles/debian_physical_machine/tasks/main.yml
  • roles/centos_physical_machine/tasks/main.yml

It misses enable: true and state: started

@AntoineDupre AntoineDupre changed the title Docker service, add missing enable: true and state: started [Fix] Docker service, add missing enable: true and state: started Mar 2, 2026
@insatomcat
Copy link
Member

insatomcat commented Mar 3, 2026

not quite sure about this one for 3 reasons:

  1. docker was (historically) only needed for the ptpstatus service, but it's not true anymore, docker is currently not needed to what I can recall
  2. All this (libvirt stuff, ptpstatus stuff...) should be in the hypervisor role anyway, it's not needed on an observer
  3. even for upcoming container needs (I'm thinking prometheus exporter for instance), we are most likely transitionning to podman Podman & Docker TSC#43

@AntoineDupre
Copy link
Contributor Author

I get your points.
Currently, the tasks exists and does nothing. I assumed that docker was expected to run as a service, but instead, the task shall just be removed.

Can i convert this PR to remove this docker service task ?

@AntoineDupre AntoineDupre force-pushed the docker-service-enable branch from 37fc4fe to fff3884 Compare March 3, 2026 09:03
@insatomcat
Copy link
Member

yes

@AntoineDupre AntoineDupre force-pushed the docker-service-enable branch from fff3884 to c8839d0 Compare March 3, 2026 09:28
@AntoineDupre AntoineDupre changed the title [Fix] Docker service, add missing enable: true and state: started [Fix] Remove docker service tasks Mar 3, 2026
Signed-off-by: Antoine Dupre <antoine.dupre@savoirfairelinux.com>
@AntoineDupre AntoineDupre force-pushed the docker-service-enable branch from c8839d0 to 1356e6a Compare March 3, 2026 09:30
@insatomcat insatomcat merged commit 6ec1158 into seapath:main Mar 3, 2026
4 of 6 checks passed
@AntoineDupre AntoineDupre deleted the docker-service-enable branch March 3, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants