fix(ci): add setup-node to release test job to fix npm install failure#33
Merged
seanseannery merged 2 commits intomainfrom Mar 7, 2026
Merged
fix(ci): add setup-node to release test job to fix npm install failure#33seanseannery merged 2 commits intomainfrom
seanseannery merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
testjob into two parallel jobs:test— Go unit tests onubuntu-latestinstall-test— install smoke tests onmacos-latest(has Homebrew pre-installed)releasejob now waits on both (needs: [test, install-test])GITHUB_TOKENin theinstall-testjob environmentinstall.shto passAuthorization: Bearer $GITHUB_TOKENheader to GitHub API when env var is setnpm_install.jsto pass the token header and add error guards on the API response (release.message, missingrelease.assets)Why do we need this?
Two failures in the install smoke tests:
spawn sh ENOENT— npm couldn't run the postinstall hook without proper Node setup (fixed by moving tomacos-latestwithsetup-node)curl: 403/Cannot read properties of undefined (reading 'find')— GitHub API rate limits unauthenticated requests from Actions runners. PassingGITHUB_TOKENauthenticates the requests (5000/hr limit instead of 60/hr)New modules or other dependencies introduced
None.
How was this tested?
Will verify by re-running the release workflow after merge. All three install methods (curl, brew, npm) should pass on the macOS runner.