Add additional logging around known spot of errors to try and gather more info #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbrooks
force-pushed
the
add-logging-around-error-with-jdk21
branch
2 times, most recently
from
8b4b67e to
0571bac
Compare
jamesbrooks
changed the title
jamesbrooks
force-pushed
the
add-logging-around-error-with-jdk21
branch
from
0571bac to
50070a3
Compare
jamesbrooks
requested review from
AnejaKarina,
DamonShi1024,
GWGEddie,
bigmasonwang and
johnjunjiezhao
DamonShi1024
approved these changes
Nov 7, 2025
johnjunjiezhao
approved these changes
Nov 9, 2025
bigmasonwang
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
The printing is still crashing out and causing issues, the current logs I don't reveal too much - possibly that the address of the printer coming back from Windows may be manged and wrong, hoping that this extra logging might reveal the issue.
WHAT
openjdk:19-jdk-busteras it is not available anymore, replaced it with an equivalent image.I haven't done Java in forever so the syntax and build config updates we're provided by Claude, thanks Claude <3.