-
Notifications
You must be signed in to change notification settings - Fork 93
Add support for rock3b board #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Indanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised you copied the current rockpro64 timer driver, and probably the serial driver too I guess (haven't checked).
Please don't do that, just adapt the current drivers so it's suitable for both boards and use a symlink here to make it compile.
Indanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting in the right direction, but still unnecessary code duplication remaining.
Indanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tidy up the commit history a bit.
Once that's done and the copyright mess is fixed, it's good to go.
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
|
@Indanz is there anything else I should do to get this merged? I see some failures in the HW runs but I fail to understand why they are happening (my code did not touch these platforms at all). |
I don't think so. Just bring seL4 up-to-date so I can merge it I think. @lsf37, do you have anything?
They're unrelated. Our CI system is not the most stable at the moment, not sure what's going on, people messing around in the server room or whatever. |
|
All good to go from my side. The remaining zcu106 failure is the known flakiness of that particular board in the machine queue. |
Adds support for Radxa Rock3b board. Based on the implementation of rockpro64 board.