Skip to content

Conversation

@JDuchniewicz
Copy link
Contributor

Adds support for Radxa Rock3b board. Based on the implementation of rockpro64 board.

Copy link
Contributor

@Indanz Indanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised you copied the current rockpro64 timer driver, and probably the serial driver too I guess (haven't checked).

Please don't do that, just adapt the current drivers so it's suitable for both boards and use a symlink here to make it compile.

Copy link
Contributor

@Indanz Indanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting in the right direction, but still unnecessary code duplication remaining.

@Indanz Indanz added the hw-test sel4test hardware builds + runs label Dec 1, 2025
Copy link
Contributor

@Indanz Indanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tidy up the commit history a bit.

Once that's done and the copyright mess is fixed, it's good to go.

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
@JDuchniewicz
Copy link
Contributor Author

@Indanz is there anything else I should do to get this merged? I see some failures in the HW runs but I fail to understand why they are happening (my code did not touch these platforms at all).

@Indanz
Copy link
Contributor

Indanz commented Dec 9, 2025

@Indanz is there anything else I should do to get this merged?

I don't think so. Just bring seL4 up-to-date so I can merge it I think. @lsf37, do you have anything?

I see some failures in the HW runs but I fail to understand why they are happening (my code did not touch these platforms at all).

They're unrelated. Our CI system is not the most stable at the moment, not sure what's going on, people messing around in the server room or whatever.

@lsf37
Copy link
Member

lsf37 commented Dec 9, 2025

All good to go from my side. The remaining zcu106 failure is the known flakiness of that particular board in the machine queue.

@lsf37 lsf37 merged commit 07a7e15 into seL4:master Dec 9, 2025
153 of 170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hw-test sel4test hardware builds + runs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants