ltimer: use platsupport export where it makes sense #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indanz
approved these changes
May 29, 2025
Contributor
Indanz
left a comment
Indanz
left a comment
There was a problem hiding this comment.
Other than my request to change the name of LibPlatSupportNoPlatformLtimer in the other PR, this looks good to me.
Contributor
Author
|
|
midnightveil
force-pushed
the
ltimer-use-platsupport
branch
from
91304e4 to
1a3ef29
Compare
In libplatsupport, we know which platforms do not support an ltimer implementation, so rather than duplicating them, we can re-use the cmake config variable here. However, this needs to be moved after util_libs_import_libraries() for the config to appear, but before config_option for it to be generated in the gen_config.h file. I have tested this with: - maaxboard (supports timer, tests enabled) - zynqmp (supports timer, tests disabled) - cheshire (no timer support, tests disabled) Signed-off-by: julia <git.ts@trainwit.ch>
Signed-off-by: Indan Zupancic <indan@nul.nu>
midnightveil
force-pushed
the
ltimer-use-platsupport
branch
from
06ab6bd to
2120b82
Compare
midnightveil
added a commit
to midnightveil/seL4_util_libs
that referenced
this pull request
Jul 2, 2025
The if statements were not strictly equivalent and broke the camkes timer component builds: https://github.com/seL4/util_libs/pull/196/files#r2178857087 Ref: seL4/sel4test#142 Signed-off-by: julia <git.ts@trainwit.ch>
midnightveil
added a commit
to midnightveil/seL4_util_libs
that referenced
this pull request
Jul 2, 2025
The if statements were not strictly equivalent and broke the camkes timer component builds: https://github.com/seL4/util_libs/pull/196/files#r2178857087 Ref: seL4/sel4test#142 Signed-off-by: julia <git.ts@trainwit.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nonfunctional change, purely a decoupling of configs. Depends on seL4/util_libs#196 to be merged first.
Test with: seL4/util_libs#196
In libplatsupport, we know which platforms do not support an ltimer implementation, so rather than duplicating them, we can re-use the cmake config variable here.
However, this needs to be moved after util_libs_import_libraries() for the config to appear, but before config_option for it to be generated in the gen_config.h file.
I have tested this with: