Add utility functions for allocating 'used' memory #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulder
requested changes
May 2, 2025
Contributor
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
Can you also fix the formatting of this PR.
PS: pls double check you pre-commit is not running in the CI.
| } | ||
|
|
||
| inline void free_memory(void* mem){ | ||
| use_memory(mem); |
Contributor
There was a problem hiding this comment.
I'm not sure about this. Why do you think we need this?
Contributor
Author
There was a problem hiding this comment.
Not sure if I had a specific intent in mind with this, other than to have both a function for allocation and freeing memory that automatically "uses" the memory. In hindsight, I don't see any realistic use cases for this at the moment to be honest.
I guess we remove it then?
vulder
reviewed
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.