[Metadata - CompositeKeys] Validate that primary key columns are unique#2840
Conversation
pvk-developer
requested review from
fealho and
sarahmish
and removed request for
a team
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/metadata-composite-keys #2840 +/- ##
================================================================
Coverage 98.07% 98.08%
================================================================
Files 73 73
Lines 8278 8284 +6
================================================================
+ Hits 8119 8125 +6
Misses 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
| """Test setting a composite key that has repeated columns multiple times.""" | ||
| # Setup | ||
| instance = SingleTableMetadata() | ||
| instance.columns = {'column': {'sdtype': 'id'}, 'column_b': {'sdtype': 'id'}} |
There was a problem hiding this comment.
can you add one more column ('column_c': {'sdtype': 'id'}) to make sure it doesn't appear in the duplicates list?
3 participants
Resolves #2825
CU-86b8n8h1h