Skip to content

Add support for auto-detect when a primary key is also a foreign key in Metadata#2835

Merged
gsheni merged 8 commits intomainfrom
issue-2788-metadata-autodetect-pk-is-fk-column_name_match
Mar 4, 2026
Merged

Add support for auto-detect when a primary key is also a foreign key in Metadata#2835
gsheni merged 8 commits intomainfrom
issue-2788-metadata-autodetect-pk-is-fk-column_name_match

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Mar 2, 2026

@gsheni gsheni requested review from fealho and frances-h March 2, 2026 23:14
@gsheni gsheni self-assigned this Mar 2, 2026
@gsheni gsheni requested a review from a team as a code owner March 2, 2026 23:14
@gsheni gsheni removed the request for review from a team March 2, 2026 23:14
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.12%. Comparing base (9c67fa0) to head (afe04ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2835   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          73       73           
  Lines        8177     8177           
=======================================
  Hits         8024     8024           
  Misses        153      153           
Flag Coverage Δ
integration 75.59% <ø> (+0.07%) ⬆️
unit 97.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsheni gsheni requested a review from sarahmish March 3, 2026 22:07
gsheni and others added 2 commits March 3, 2026 18:54
Co-authored-by: Sarah Alnegheimish <40212131+sarahmish@users.noreply.github.com>
@gsheni gsheni requested a review from sarahmish March 4, 2026 00:12
@gsheni gsheni merged commit affa5cd into main Mar 4, 2026
47 checks passed
@gsheni gsheni deleted the issue-2788-metadata-autodetect-pk-is-fk-column_name_match branch March 4, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata should be able to auto-detect cases where a primary key is also a foreign key (column_name_match algorithm)

3 participants