Stop metadata's remove_column from removing unexpected relationships#2814
Stop metadata's remove_column from removing unexpected relationships#2814
remove_column from removing unexpected relationships#2814Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2814 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 73 73
Lines 8148 8155 +7
=======================================
+ Hits 7995 8002 +7
Misses 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frances-h
left a comment
frances-h
left a comment
There was a problem hiding this comment.
Looks good! Just one naming suggestion for clarity
sdv/metadata/metadata.py
Outdated
|
|
||
| self.relationships = updated_relationships | ||
|
|
||
| def _remove_column_relationships(self, table_name, column_name): |
There was a problem hiding this comment.
Can we rename this to _remove_relationships_by_column or something? The current name is a little confusing since a column_relationship is a distinct concept.
Maybe we should also rename _remove_matching_relationships to _remove_relationships_by_table so that the intended use of each helper is clearer.
4 participants
CU-86b8jf8ft, Resolve #2813