Conversation
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 98.36% 98.40% +0.03%
==========================================
Files 42 43 +1
Lines 611 626 +15
==========================================
+ Hits 601 616 +15
Misses 7 7
Partials 3 3
Continue to review full report at Codecov.
|
tsubus
force-pushed
the
stochastic_rsi
branch
2 times, most recently
from
a6c5054 to
e4d4a5d
Compare
sdcoffey
left a comment
sdcoffey
left a comment
There was a problem hiding this comment.
Loving the new indicators, keep them coming! Just a couple questions on this one
indicator_stochastic_rsi.go
Outdated
| } | ||
|
|
||
| type rsiDIndicator struct { | ||
| k Indicator |
There was a problem hiding this comment.
Can we give this a more descriptive name than k?
indicator_stochastic_rsi.go
Outdated
| maxRSI := sri.maxRSI.Calculate(index) | ||
|
|
||
| if minRSI.EQ(maxRSI) { | ||
| return big.NewDecimal(math.Inf(1)) |
There was a problem hiding this comment.
Why Inf here? Wouldn't 0 be a better dummy value?
There was a problem hiding this comment.
The reason it's Inf is simply because dividing by 0 tends to infinity. I'll set it to the maximum value (100).
2 participants
https://www.investopedia.com/terms/s/stochrsi.asp