Skip to content

Reorg introduce api package containing Entry interface #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steiler wants to merge 14 commits into
base: main
Choose a base branch
from
+4,486 −3,341
Open

Reorg introduce api package containing Entry interface #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a27eedb
move entry and related to api package
steiler Feb 18, 2026
ed87e06
adjust makefile referencing path
steiler Feb 18, 2026
efa72f3
GetByOwner to ops and nonRevertiveInfo fix
steiler Feb 19, 2026
9bd0cfe
add mock forsdcpbpath inteface
steiler Feb 19, 2026
3492c4b
wire nonrevertive paths
steiler Feb 24, 2026
651c414
adjust go mod & fix test
steiler Feb 24, 2026
a5f59f7
reorg
steiler Feb 27, 2026
7f8fe08
split further
steiler Mar 2, 2026
28b180f
update
steiler Mar 3, 2026
0566ae3
fill new KeyName attribute of BlameTreeElement
steiler Mar 4, 2026
c8a5bcd
GetDeviations use pool
steiler Mar 5, 2026
2355491
address comments part1
steiler Mar 13, 2026
572db0f
refactor(validation): split validator logic into dedicated files and …
steiler Mar 13, 2026
eddffb1
fix updating revertiveness
steiler Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ mocks-gen: mocks-rm ## Generate mocks for all the defined interfaces.
mockgen -package=mockcacheclient -source=pkg/cache/cache.go -destination=$(MOCKDIR)/mockcacheclient/client.go
mockgen -package=mockcacheclient -source=pkg/cache/cacheClientBound.go -destination=$(MOCKDIR)/mockcacheclient/clientbound.go
mockgen -package=mocktarget -source=pkg/datastore/target/target.go -destination=$(MOCKDIR)/mocktarget/target.go
mockgen -package=mockTreeEntry -source=pkg/tree/entry.go -destination=$(MOCKDIR)/mocktreeentry/entry.go
mockgen -package=mockTreeEntry -source=pkg/tree/api/entry.go -destination=$(MOCKDIR)/mocktreeentry/entry.go
mockgen -package=mocksdcpbpath -source=pkg/tree/api/sdcpb_path.go -destination=$(MOCKDIR)/mocksdcpbpath/sdcpb_path.go

.PHONY: mocks-rm
mocks-rm: ## remove generated mocks
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/sdcio/cache v0.0.38
github.com/sdcio/logger v0.0.3
github.com/sdcio/schema-server v0.0.34
github.com/sdcio/sdc-protos v0.0.50
github.com/sdcio/sdc-protos v0.0.51-0.20260304120533-f0e62d96331e
Copy link
Contributor

@alexandernorth alexandernorth Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess sdc-protos should be tagged and this updated before this PR is merged

Copy link
Collaborator Author

@steiler steiler Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly

github.com/sdcio/yang-parser v0.0.12
github.com/spf13/cobra v1.10.2
github.com/spf13/pflag v1.0.10
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ github.com/sdcio/logger v0.0.3 h1:IFUbObObGry+S8lHGwOQKKRxJSuOphgRU/hxVhOdMOM=
github.com/sdcio/logger v0.0.3/go.mod h1:yWaOxK/G6vszjg8tKZiMqiEjlZouHsjFME4zSk+SAEA=
github.com/sdcio/schema-server v0.0.34 h1:NNDOkvtUMONtBA7cVvN96F+FWGD/Do6HNqfchy9B8eI=
github.com/sdcio/schema-server v0.0.34/go.mod h1:6t8HLXpqUqEJmE5yNZh29u/KZw0jlOICdNWns7zE4GE=
github.com/sdcio/sdc-protos v0.0.50 h1:aR6Av1QMTFNXKKxnrz8vlIXQ0y21lxQJEMut1oLd2Bg=
github.com/sdcio/sdc-protos v0.0.50/go.mod h1:huh1QVE023w+reU2Gt6h1f83R3lJidcFLbQje7cMY1M=
github.com/sdcio/sdc-protos v0.0.51-0.20260304120533-f0e62d96331e h1:oe0q40PuBLd4M7X9D5UHnfhN0Tv/RXZE/eQOKOSIlCw=
github.com/sdcio/sdc-protos v0.0.51-0.20260304120533-f0e62d96331e/go.mod h1:huh1QVE023w+reU2Gt6h1f83R3lJidcFLbQje7cMY1M=
github.com/sdcio/yang-parser v0.0.12 h1:RSSeqfAOIsJx5Lno5u4/ezyOmQYUduQ22rBfU/mtpJ4=
github.com/sdcio/yang-parser v0.0.12/go.mod h1:CBqn3Miq85qmFVGHxHXHLluXkaIOsTzV06IM4DW6+D4=
github.com/sirikothe/gotextfsm v1.0.1-0.20200816110946-6aa2cfd355e4 h1:FHUL2HofYJuslFOQdy/JjjP36zxqIpd/dcoiwLMIs7k=
Expand Down
55 changes: 55 additions & 0 deletions mocks/mocksdcpbpath/sdcpb_path.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading