You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.
nonet_generator.py, line 1 [r1] (raw file):
I would recommend cleaning up any unused files when you turn this in, it helps us figure out what to grade and is much cleaner
nonet_generator_actual.py, line 66 [r1] (raw file):
These are very specific stop and start conditions-- it would be more modular to take start and stop patterns as arguments for the function so that it could be adapted to other text.
nonet_generator_actual.py, line 157 [r1] (raw file):
It would be a little cleaner to build up a single string (string += poem + '\n'), then write it as a a whole at the end (f.write(string + '\n\n\n'))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.