fix sclang restart not working on some systems#66
Open
chairbender wants to merge 1 commit intoscztt:developfrom
Open
fix sclang restart not working on some systems#66chairbender wants to merge 1 commit intoscztt:developfrom
chairbender wants to merge 1 commit intoscztt:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65 .
Don't really have time to test super thoroughly, but this fixes the "restart sclang" on my system and doesn't seem to break other stuff. The issue seemed to be that this.serverPorts was undefined and calling dispose on it caused issues.
I think maybe because the language server was picking an arbitrary free port rather than suggesting a specific port (I see "[LANGUAGESERVER.QUARK] suggestedServerPortRange: nil" in the logs which is always how it's worked for me)? Maybe that's why it was undefined? I'm guessing depending on your setup, one might define a specific port to use and wouldn't run into this issue in that situation.
FYI with this fix, I see a message in the output after restarting "[Error - 7:58:26 PM] Stopping server timed out" after it restarts, but I haven't noticed any actual problem as a result of that (and even checking task manager, I can see that it's not doing something awful like spawning more and more sclang / scysnth instances with each restart).