Add code evaluation settings for blink and post evaluate message#13
Open
okhick wants to merge 6 commits intoscztt:developfrom
Open
Add code evaluation settings for blink and post evaluate message#13okhick wants to merge 6 commits intoscztt:developfrom
okhick wants to merge 6 commits intoscztt:developfrom
Conversation
okhick
commented
Mar 25, 2023
|
|
||
| return (text: string, isError: boolean) => { | ||
| if (evaluateCount == currentEvaluateCount) | ||
| if (evaluateCount != currentEvaluateCount) |
Contributor
Author
There was a problem hiding this comment.
Pretty sure this is a copy/paste error from line 80.
okhick
changed the title
Contributor
Author
|
Reworked it a little. This PR now includes the following:
This is accomplished by setting |
okhick
commented
Apr 10, 2023
Comment on lines
-231
to
+233
| interface EvaluateSelectionOptions extends WorkDoneProgressOptions { | ||
| } | ||
| type EvaluateSelectionOptions = WorkDoneProgressOptions; | ||
|
|
||
| interface EvaluateSelectionRegistrationOptions extends EvaluateSelectionOptions, TextDocumentRegistrationOptions, StaticRegistrationOptions { | ||
| } | ||
| type EvaluateSelectionRegistrationOptions = EvaluateSelectionOptions&TextDocumentRegistrationOptions&StaticRegistrationOptions; |
Contributor
Author
There was a problem hiding this comment.
These make more sense to me as types; not interfaces.
scztt
force-pushed
the
develop
branch
2 times, most recently
from
eec81a4 to
27e4aa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evaluation background decorator had a bug where instead of applying the timeout value, it just flashed. I also shortened the timeout to 600ms, which I think is the SCIDE default. This timeout value could probably be a setting someday.