validator/tests: add test_ prefix to all tests#247
Draft
QuerthDP wants to merge 3 commits intoscylladb:masterfrom
Draft
validator/tests: add test_ prefix to all tests#247QuerthDP wants to merge 3 commits intoscylladb:masterfrom
test_ prefix to all tests#247QuerthDP wants to merge 3 commits intoscylladb:masterfrom
Conversation
Since the change we may create the indexes with different than default vector index parameters like e.g. 'similarity_function'.
QuerthDP
changed the title
test_ prefix to all tests
Member
Author
|
Will mark this as ready after #241 is merged. |
Collaborator
|
I like this change, but let's @ewienik do the final statement. |
Add tests to validate the results of vector_similarity() function. Refs: scylladb/scylladb#25993
We need to be able to simply differ the test cases from the utility functions implemented in a test file. This patch introduces a conversion that each test should be named with the `test_` prefix. The test name should be the same as test function name but without the `test_` prefix, as this would duplicate the test keywords in logs. From this commit, let's keep the conversion for all future tests.
QuerthDP
force-pushed
the
rename-tests
branch
from
58b539d to
07ca62b
Compare
Member
Author
|
Changelog: |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to simply differ the test cases from the utility
functions implemented in a test file.
This patch introduces a conversion that each test should be named
with the
test_prefix.The test name should be the same as test function name but without
the
test_prefix, as this would duplicate the test keywords in logs.From this commit, let's keep the conversion for all future tests.