Open
Conversation
This removes all internals of metadata classes, leaving only the public API without any implementation. This simplification is done, to better understand changes to the public API that will be done in the following commits.
This was a metadata specific to DSx service
The plan is to let the rust driver handle all metadata fetching. This means we will be able to retrieve all the metadata in a sync way. This commit updates the metadata class API to expose all endpoints in a sync way. This is meant to split the API changes into smaller parts, to better understand the differences between the old and new API.
This is a no longer used part of the code that wasn't exposed in the public API
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy DataStax-style (DSx) metadata implementation pieces to simplify the codebase ahead of upcoming metadata API work.
Changes:
- Removed the legacy schema parsing implementation (
schema-parser.js) and its related unit coverage. - Removed the metadata event debouncer implementation and its tests.
- Replaced many
Metadatabehaviors with placeholderTODOthrows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit-not-supported/event-debouncer-tests.js | Deleted tests for the removed event debouncer. |
| test/unit-broken/metadata-tests.js | Removed tests that depended on the deleted schema parser helper. |
| lib/metadata/schema-parser.js | Deleted legacy schema parsing implementation. |
| lib/metadata/index.js | Stripped most metadata functionality; many methods now throw TODO: Not implemented. |
| lib/metadata/event-debouncer.js | Deleted event debouncer implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wprzytula
reviewed
Mar 20, 2026
| * If a `callback` is provided, the callback is invoked when the keyspace metadata refresh completes. | ||
| * Otherwise, it returns a `Promise`. | ||
| * @param {Boolean|Function} [waitReconnect] Determines if it should wait for reconnection in case the control connection is not | ||
| * @param {Boolean} [waitReconnect] Determines if it should wait for reconnection in case the control connection is not |
Contributor
There was a problem hiding this comment.
❓ Why was this Boolean|Function???
Contributor
Author
There was a problem hiding this comment.
Someone could skip waitReconect argument and provide just callback.
Totally JS thing to do
wprzytula
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a second part of new metadata implementation.
The goal of this PR is to remove existing DSx logic inside Metadata class, which we will not use, so that we can better understand the changes to the API we will introduce in the following PRs
Refs: #268, #261
Refactors were made with use of LLMs