Skip to content

Casync clean #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adespawn wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Casync clean #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd67403
Custom async napi bridging
adespawn Mar 12, 2026
1b2b1fa
Fix parametrized select
adespawn Mar 16, 2026
8c410ab
Some refactor
adespawn Mar 18, 2026
9bf0cdd
Wrapper over DeferredPtr
adespawn Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/logic/parametrized_select.js
View file
Open in desktop
Copy link
Contributor

@wprzytula wprzytula Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message:
There was a but -> There was a bug

Copy link
Contributor

@wprzytula wprzytula Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lead -> led

Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function selectWithRows(number) {
utils.prepareDatabase(client, utils.tableSchemaBasic, next);
},
async function insert(next) {
utils.insertSimple(client, 10, next);
utils.insertSimple(client, number, next);
},
async function query(next) {
await utils.queryWithRowCheck(client, number, iterCnt, next);
Expand Down
5 changes: 5 additions & 0 deletions lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ const { HostMap } = require("./host.js");
// eslint-disable-next-line no-unused-vars
const { QueryOptions } = require("./query-options.js");

// Initialize the direct-poll bridge once per process.
// This sets up the Tokio reactor thread and the wake mechanism used by all
// bridged async Rust functions (session queries, paging, etc.).
rust.initPollBridge();
Comment on lines +32 to +35
Copy link
Contributor

@wprzytula wprzytula Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ When is this executed? Is this guaranteed to be executed at most once? Is this idempotent?

Copy link
Contributor Author

@adespawn adespawn Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this executed

When the file is first imported

Is this guaranteed to be executed at most once

Almost always yes: https://nodejs.org/docs/latest/api/modules.html#caching

Is this idempotent

No. The following calls will lead to a panic.

Copy link
Contributor

@wprzytula wprzytula Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this idempotent

Do you think it's worth making it idempotent, i.e. setting an atomic flag at the beginning of its execution that prevents double initialization?


/**
* Represents a database client that maintains multiple connections to the cluster nodes, providing methods to
* execute CQL statements.
Expand Down
Loading
Loading