Changed the default ports to avoid conflict with The Onion Router daemon#1
Open
fvcr wants to merge 1 commit intoscuty2000:masterfrom
Open
Changed the default ports to avoid conflict with The Onion Router daemon#1fvcr wants to merge 1 commit intoscuty2000:masterfrom
fvcr wants to merge 1 commit intoscuty2000:masterfrom
Conversation
Owner
|
Thank you for contributing! I'll have a look in a few days, i'm busy at work for now. |
Owner
|
Hi, I completely forgot to reply you. I assume that it would be better to make the ports configurable directly in the constructor instead of editing the code to edit them. I'm gonna take a look at it this week (I hope!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to run TorRequest using the same Tor process, alternatively,
I thought it might be feasible to change the default ports to avoid conflicts.
Were you able to successfully run it with the tor daemon running?
I would like to know your opinion and thanks for continuing the project.