Open
Conversation
Pull Request Test Coverage Report for Build 38
💛 - Coveralls |
Contributor
Author
|
I've now upgraded bs-platform and am trying to quiet down all the new warnings about deprecated booleans.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to quiet down compiler warnings of bs-ajv.
Somehow a bunch of redundant externals were declared, which was the majority of the warnings.
I removed one unused function (it didn't seem to match the documented interface of the foreign function anyhow) and exposed one (also unused) function in the
Ajvmodule signature.The rest are unused variables in pattern match destructurings and such...