Skip to content

refmt and compiler warnings#11

Open
dvisztempacct wants to merge 7 commits intoscull7:masterfrom
dvisztempacct:master
Open

refmt and compiler warnings#11
dvisztempacct wants to merge 7 commits intoscull7:masterfrom
dvisztempacct:master

Conversation

@dvisztempacct
Copy link
Contributor

I wanted to quiet down compiler warnings of bs-ajv.

Somehow a bunch of redundant externals were declared, which was the majority of the warnings.

I removed one unused function (it didn't seem to match the documented interface of the foreign function anyhow) and exposed one (also unused) function in the Ajv module signature.

The rest are unused variables in pattern match destructurings and such...

@coveralls
Copy link

coveralls commented May 16, 2018

Pull Request Test Coverage Report for Build 38

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 40 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 61.35%

Files with Coverage Reduction New Missed Lines %
src/Ajv_options.bs.js 19 26.32%
src/Ajv.bs.js 21 57.14%
Totals Coverage Status
Change from base Build 35: -0.3%
Covered Lines: 141
Relevant Lines: 226

💛 - Coveralls

@dvisztempacct
Copy link
Contributor Author

I've now upgraded bs-platform and am trying to quiet down all the new warnings about deprecated booleans....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants