Merged
Conversation
cboh4
requested review from
Cashmaney,
liorbond,
toml01 and
valdok
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cboh4
force-pushed
the
enable-cron-module
branch
from
f010f62 to
e8863ae
Compare
Major refactoring of the cron module to remove ExecutionStage distinction and consolidate all scheduled transactions through a single execution path. BREAKING CHANGES: - Removed ExecutionStage enum (BEGIN_BLOCKER/END_BLOCKER) - All scheduled messages now execute via EndBlock → Tendermint - Changed cron module authority from cron module address to gov module address Refactoring: - Moved encryption logic to separate encryption.go file - Changed from deterministic to fixed Curve25519 keypair encryption - Updated module private key to new hardcoded value - Simplified GetScheduledMsgs signature (removed execution_stage parameter) - Removed BeginBlock execution code from compute module Fixes: - Fix LastExecuteHeight to record execution block (N+1) instead of prep block (N) - Auto-create cron module account if missing (prevents consensus failures) - Fix sequence number handling for multiple transactions per block - Improve error handling in EndBlock (log errors instead of failing consensus) Improvements: - Set hardcoded gas limit (5M) and zero fees for scheduled transactions - Change several logs to debug level for cleaner output - Re-enable authority validation in message handlers Scheduled transactions can now be decrypted using standard secretcli commands thanks to the fixed keypair approach.
cboh4
force-pushed
the
enable-cron-module
branch
from
1b21f27 to
b8c6b29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.