Add FromRow/ToRow instances for Solo
#85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crtschin
force-pushed
the
dev-crtschin-add-instances-solo
branch
from
399804f to
e8819b6
Compare
Collaborator
|
I'm not a fan of this unless we remove the instance for Identity (which might not be worth it), because there will be two ways of fetching a single column, which ultimately results in inconsistency of using one or the other. |
Collaborator
Author
Understandable, I'm not super hung up on this. Considering I'm not keen to change this everywhere, I'll close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big thing, but I always get a little bit confused seeing
runIdentitywhen we need a single value per row from a query. This PR adds instances forSolo.