Skip to content

Conversation

@eirikurj
Copy link
Contributor

Purpose

The current environment that mypy runs in does may not have the dependencies needed, e.g., numpy, mpi4py etc.

Instead, running mypy in our containers, or installing large number of python packages, we leave this up to the user and just check if there is a requirements.txt present in the repository and pip install that.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

Copy link

@DavidAnderegg DavidAnderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. thanks

@DavidAnderegg DavidAnderegg merged commit 7317fef into dev Nov 26, 2025
1 check passed
@DavidAnderegg DavidAnderegg deleted the feature-mypy-requirements branch November 26, 2025 14:35
@eirikurj eirikurj mentioned this pull request Dec 3, 2025
13 tasks
@eirikurj eirikurj restored the feature-mypy-requirements branch December 3, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants