Skip to content

Forms: Fix passing extra data to radio and multi checkbox fields #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meloniq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Forms: Fix passing extra data to radio and multi checkbox fields #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Forms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,9 @@ class scbRadiosField extends scbSelectField {
* @return string
*/
protected function _render_specific( $args ) {
$args = wp_parse_args( $args, array(
'extra' => array(),
) );

if ( array( 'foo' ) === $args['selected'] ) {
// radio buttons should always have one option selected
Expand All @@ -857,6 +860,7 @@ protected function _render_specific( $args ) {
'type' => 'radio',
'value' => $value,
'checked' => ( $value == $args['selected'] ),
'extra' => $args['extra'],
'desc' => $title,
'desc_pos' => 'after',
) );
Expand Down Expand Up @@ -895,6 +899,7 @@ protected function _render( $args ) {
$args = wp_parse_args( $args, array(
'numeric' => false, // use numeric array instead of associative
'checked' => null,
'extra' => array(),
) );

if ( ! is_array( $args['checked'] ) ) {
Expand All @@ -908,6 +913,7 @@ protected function _render( $args ) {
'type' => 'checkbox',
'value' => $value,
'checked' => in_array( $value, $args['checked'] ),
'extra' => $args['extra'],
'desc' => $title,
'desc_pos' => 'after',
) );
Expand Down