Make visuals sticky #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added config.visualCacheTicks (Set to 20) Increased visual timeout based on config.visualCacheTicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a resubmission of #10 due to accidental closing
This removes gametime from visuals redis keys and multiplies the timeout for visuals by config.visualCacheTicks (Set to 20).
This allows visuals to be 'sticky' after rendering, reducing CPU usage by not having to render visuals every tick.
As discussed in #10, we could add a method to RoomVisual to toggle sticky status (Use visualCacheTicks if enabled, otherwise 1)
Companion PR for backend at screeps/backend-local#7