Refactor for Request Logging middleware #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeisler
force-pushed
the
refactor_for_logging
branch
2 times, most recently
from
5636d15 to
b51b7c3
Compare
zeisler
force-pushed
the
refactor_for_logging
branch
from
e43a86f to
b709790
Compare
lib/rory/application.rb
Outdated
| use_middleware Rack::PostBodyContentTypeParser | ||
| use_middleware Rack::CommonLogger, logger | ||
| use_middleware Rory::RequestParameterLogger, logger, :filters => parameters_to_filter | ||
| def initializer_default_middleware |
Member
There was a problem hiding this comment.
initialize_default_middleware, I assume
…elongs in Rory so I can at least hide it.
so that RfLogger can replace the default.
zeisler
force-pushed
the
refactor_for_logging
branch
6 times, most recently
from
8922773 to
77c7236
Compare
Solution is to call .warmup on boot. A warning will be logged to notify user of to call this method if not already.
zeisler
force-pushed
the
refactor_for_logging
branch
from
77c7236 to
b9c1ae2
Compare
Contributor
Author
|
Hey @ravigadad I know this is a big one. Here is what it includes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.