Release 0.9.0 #416
Closed
Release 0.9.0 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMRuiz
approved these changes
Jan 23, 2025
VMRuiz
left a comment
VMRuiz
left a comment
There was a problem hiding this comment.
I hope you used a tool to refactor this code and didn’t rewrite it line by line! 😄
Member
Author
|
Yeah, most changes come from adding pyupgrade to pre-commit*. Reviewing separate commits may be easier here. * I added pyupgrade for functional reasons, not for cleanup. There were old stdlib imports preventing the code from working in newer Python versions, and pyupgrade solved that automatically. |
Gallaecio
commented
Jan 23, 2025
Member
Author
|
Closing. Will instead prepare a 0.7.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the code base to support the latest versions of Python, so that https://github.com/scrapinghub/scrapy-frontera tests can pass (scrapinghub/scrapy-frontera#14).
I got tests to pass, but skipped all those that require running a service, as I imagine it would be non-trivial to get them to pass in GitHub Actions, and I was not sure about using https://github.com/tox-dev/tox-docker to get the services running locally. Not sure if I should try to test those manually at least, I wonder if there are any current users of those service-based features.
To do: