Skip to content

Conversation

@jgkamat
Copy link

@jgkamat jgkamat commented Feb 20, 2019

While doing more extensive testing on my fork, I found a small bug.

On the rule:

/\.accountant\/[0-9]{2,9}\/$/$script,stylesheet,third-party,xmlhttprequest

taken from easylist, you split on the first $, then strip the left and right /, which leaves \ at the end (which is an invalid regexp). It happens to not error out during regex compilation because it is followed by a | (I think), which can be properly escaped.

See this snippet for ubo's implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant