fix(graphics): measure ellipsis before shrinking in force_fit_string #7165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
requested changes
Dec 28, 2025
Contributor
Goober5000
left a comment
Goober5000
left a comment
There was a problem hiding this comment.
Good catch! Please add a bit more information to the comment.
| str[len] = ellipsis_char; | ||
| } | ||
|
|
||
| // measure with ellipsis before shrinking further |
Contributor
There was a problem hiding this comment.
Add a note to this comment, something like (because the characters could be narrower than the characters they replaced) to explain why
Goober5000
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7161
obo: Strings were getting cut one letter shorter than they needed to be.