fix(math): correct xvec calculation in vm_vector_2_matrix_gen_vectors #7162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchristiancazares
force-pushed
the
fix/xvec-calculation
branch
from
8aaf238 to
2c2d42d
Compare
jg18
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #7157
xvec fix: When computing a perpendicular vector in the XZ plane, the x component should use yvec.z, not yvec.y. The old code produced non-orthogonal results for vectors not aligned with an axis.
rvec fix: When fvec is provided as primary and rvec is also given, the code never actually assigned rvec to xvec before using it in the cross product.